Fix clearTimeout timer leaks in AbortController fetch patterns#36
Merged
groupthinking merged 4 commits intomainfrom Feb 27, 2026
Merged
Fix clearTimeout timer leaks in AbortController fetch patterns#36groupthinking merged 4 commits intomainfrom
groupthinking merged 4 commits intomainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
railway-app
bot
temporarily deployed
to
EventRelay / EventRelay-pr-36
|
🚅 Deployed to the EventRelay-pr-36 environment in EventRelay
|
…eouts Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
railway-app
bot
temporarily deployed
to
EventRelay / EventRelay-pr-36
Copilot
AI
changed the title
[WIP] Add frontend-only video analysis pipeline with multi-strategy transcription
Fix clearTimeout timer leaks in AbortController fetch patterns
Feb 27, 2026
…b-pr-33-another-one
railway-app
bot
temporarily deployed
to
EventRelay / EventRelay-pr-36
groupthinking
approved these changes
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes timer leaks in the AbortController fetch patterns in two Next.js API routes. Previously, clearTimeout was called immediately after await fetch(...), meaning if the fetch threw an error (such as an AbortError triggered by the signal itself), the timeout would never be cleared. The fix wraps each fetch in a try/finally block so clearTimeout is guaranteed to run on all code paths. The package-lock.json changes reflect routine dependency tree cleanup (@swc/core, @cfworker/json-schema, and related peer packages removed as optional/unused, and fsevents dev flag update).
Changes:
apps/web/src/app/api/video/route.ts: Wrapped the 15-second backendfetchintry/finallyto always clear the abort timer.apps/web/src/app/api/transcribe/route.ts: Sametry/finallyfix for the 8-second backendfetch.package-lock.json: Removes entries for@swc/core,@cfworker/json-schema, and related packages that were optional peer dependencies, and updates thefseventsentry (removal of the"dev": trueflag — a commonnpm installartifact).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/web/src/app/api/video/route.ts |
Wraps 15s backend fetch in try/finally to guarantee clearTimeout runs on abort/throw |
apps/web/src/app/api/transcribe/route.ts |
Wraps 8s backend fetch in try/finally to guarantee clearTimeout runs on abort/throw |
package-lock.json |
Removes unused optional peer packages (@swc/core, @cfworker/json-schema, etc.) and updates fsevents metadata |
Base automatically changed from
claude/slack-check-status-update-R47Ph
to
main
February 27, 2026 23:05
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Suggestions:
- Missing dataconnect-generated module causes build failure with "Cannot find module" error and additional TypeScript type errors
- Missing index.ts file in embeddings package causes build failure due to entry point mismatch between package.json and TypeScript output
railway-app
bot
temporarily deployed
to
EventRelay / EventRelay-pr-36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clearTimeoutwas placed afterawait fetch(...)in both/api/videoand/api/transcriberoutes, meaning it never ran when the fetch threw (including the intentionalAbortErrorfrom the signal). This left timers pending in every error/abort path.Changes
apps/web/src/app/api/video/route.ts— Wrapped the 15s backend fetch intry/finallyso the timeout is always clearedapps/web/src/app/api/transcribe/route.ts— Same fix for the 8s YouTube backend transcript fetchAlso included in this branch (prior commits):
transcript_segmentsnow correctly readsresult.transcript?.segments?.lengthfor object-shaped transcripts, falling back toresult.transcript.lengthfor arraysENABLE_VERTEX_AIenv var now parsed as an explicit boolean ("1"/"true"/"yes") instead of raw truthiness, preventing"0"or"false"from triggering the slow Vertex AI metadata probe✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.